Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint instructions give wrong function name #275

Closed
jmeekhof opened this issue Jun 6, 2024 · 2 comments
Closed

Eslint instructions give wrong function name #275

jmeekhof opened this issue Jun 6, 2024 · 2 comments

Comments

@jmeekhof
Copy link
Contributor

jmeekhof commented Jun 6, 2024

The usage instructions for eslint don't match the exported functions made in the eslint file.
@jmeekhof
Copy link
Contributor Author

jmeekhof commented Jun 6, 2024

https://github.com/aspect-build/rules_lint/blob/main/lint/eslint.bzl

This files docstring references eslint_aspect, but the function name is lint_eslint_aspect

jmeekhof added a commit to jmeekhof/rules_lint that referenced this issue Jun 6, 2024
@jmeekhof
Correct docstring for eslint (aspect-build#275)
d3b8865
@jmeekhof jmeekhof mentioned this issue Jun 6, 2024
Merged
alexeagle added a commit that referenced this issue Jun 6, 2024
@jmeekhof @alexeagle
Correct docstring for eslint (#275) (#276)
a5ad324 
* Correct docstring for eslint (#275)

* docs update

---------

Co-authored-by: Alex Eagle <alex@aspect.dev>
@alexeagle
Copy link
Member

fixed in #276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @jmeekhof