Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use camel case in generated bin mnemonics #242

Merged
merged 6 commits into from
Jun 23, 2022

Conversation

alex-torok
Copy link
Contributor

@alex-torok alex-torok commented Jun 23, 2022

#218 added the ability to use the bin name as the default mnemonic for generated package_json.bzl entries. Some generated bin entries have underscores in their name, which is not allowed in action mnemonics.

Without this change, you can get:

Error in run: mnemonic must only contain letters and/or digits, and have non-zero length, was: "webpack_cli"

Use a CamelCase version of the bin name instead.

@alex-torok alex-torok marked this pull request as draft June 23, 2022 19:33
@alex-torok
Copy link
Contributor Author

Oops, just realized spaces are a no-go too - Error in run: mnemonic must only contain letters and/or digits, and have non-zero length, was: "webpack cli" I'll see if I can CamelCase the mnemonic.

@alex-torok alex-torok marked this pull request as ready for review June 23, 2022 19:40
@alex-torok alex-torok changed the title fix: use spaces in generated bin mnemonics fix: use CamelCase in generated bin mnemonics Jun 23, 2022
@alex-torok alex-torok changed the title fix: use CamelCase in generated bin mnemonics fix: use camel case in generated bin mnemonics Jun 23, 2022
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. Thanks for the fix. I hit this yesterday as well and Alex started fixing it and then got busy with other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants