Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: tweak ':' separator locations in package_json.bzl load paths #241

Merged
merged 1 commit into from
Jun 23, 2022
Merged

refactor: tweak ':' separator locations in package_json.bzl load paths #241

merged 1 commit into from
Jun 23, 2022

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Jun 23, 2022 •
edited
Loading

(small) BREAKING CHANGE

Examples:

load("@npm//typescript:package_json.bzl", typescript_bin = "bin")

becomes,

load("@npm//:typescript/package_json.bzl", typescript_bin = "bin")

load("@rules_foo_npm//foo/@aspect-test/a:package_json.bzl", aspect_test_a_bin = "bin")

becomes,

load("@rules_foo_npm//foo:@aspect-test/a/package_json.bzl", aspect_test_a_bin = "bin")

@gregmagolan gregmagolan requested a review from alexeagle June 23, 2022 00:35
@gregmagolan gregmagolan changed the title feat: tweak ':' separator locations in package_json.bzl load paths refactor: tweak ':' separator locations in package_json.bzl load paths Jun 23, 2022
@gregmagolan gregmagolan force-pushed the improve_package_json_load_path branch from 3bc49f8 to eb7f67d Compare June 23, 2022 00:35
@gregmagolan gregmagolan merged commit f1934d6 into aspect-build:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @alexeagle