feat: add public_hoist_packages attribute to npm_translate_lock to emulate .npmrc public-hoist-pattern[] #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
public_hoist_packages
branch
3 times, most recently
from
bd619f5 to
123f64b
Compare
alexeagle
approved these changes
Jun 17, 2022
| @@ -1,3 +1,4 @@ | |||
| # Set a custom registry for a scope that is picked up by pnpm when resolving packages; | |||
| # This affects the lockfile format and is here to cover this case. | |||
| @types:registry=https://registry.yarnpkg.com | |||
| public-hoist-pattern[]=ms | |||
There was a problem hiding this comment.
comment that bazel / rules_js won't actually see this yet, it only has effect for pnpm i
examples/npm_deps/BUILD.bazel
Outdated
| @@ -210,3 +210,24 @@ uvu_test( | |||
| ":uvu_spec", | |||
| ], | |||
| ) | |||
|
|
|||
| ####################################### | |||
| # Use case 6: depend on a hoisted npm package that wasn't a direct dependency package.json | |||
There was a problem hiding this comment.
would be nice to say which direct dependency has the ms dependency
| public_hoist_packages.extend(attr.public_hoist_packages.get(friendly_name, [])) | ||
| if unfriendly_name: | ||
| public_hoist_packages.extend(attr.patches.get(unfriendly_name, [])) | ||
| for public_hoist_package in public_hoist_packages: |
There was a problem hiding this comment.
nice short code change is a good sign that the abstractions will endure more feature sprawl :)
gregmagolan
force-pushed
the
public_hoist_packages
branch
2 times, most recently
from
176722b to
6bfc884
Compare
…ulate .npmrc public-hoist-pattern[]
gregmagolan
force-pushed
the
public_hoist_packages
branch
from
6bfc884 to
852b690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out pnpm does not encode what it hoists in its lockfile. It is a link time decision in the implementation.
This lays the foundation for supporting https://pnpm.io/npmrc#public-hoist-pattern and https://pnpm.io/npmrc#shamefully-hoist.
Follow-ups to this would be to support globs to get closer to what users can do with
.npmrc. For example,.npmrc:could be emulated with
and
.npmrc:with
Once we can do that then we could just let users use the
.npmrcfile as the source of truth instead:NB:
.npmrcis an INI file https://en.wikipedia.org/wiki/INI_file