fix: keep lockfile up to date example windows regression #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
commented
Jun 16, 2022
Comment on lines
+41
to
+43
| sha256 = "a62838a8bb32478db2cf557b59279e566d628e064f91071daf1986c32463c2c9", | ||
| strip_prefix = "bazel-lib-1.2.1", | ||
| url = "https://github.com/aspect-build/bazel-lib/archive/refs/tags/v1.2.1.tar.gz", |
There was a problem hiding this comment.
Needed for the copy_to_bin same file different target fix.
gregmagolan
reviewed
Jun 16, 2022
| @@ -12,12 +12,18 @@ js_test( | |||
| ":pnpm-lock.yaml", | |||
| ], | |||
| entry_point = "assert_lockfile_frozen.js", | |||
| env = { | |||
| "APPDATA": "unused_but_pnpm_fails_if_not_set_on_windows" | |||
kormide
commented
Jun 16, 2022
| @@ -12,12 +12,18 @@ js_test( | |||
| ":pnpm-lock.yaml", | |||
| ], | |||
| entry_point = "assert_lockfile_frozen.js", | |||
| env = { | |||
| "APPDATA": "unused_but_pnpm_fails_if_not_set_on_windows" | |||
There was a problem hiding this comment.
The script sets a store dir inside of the output tree, but pnpm still tries to resolve some path to a default cache dir. It just needs to not be undefined.
There was a problem hiding this comment.
Can you add a comment with some more context for future reference?
gregmagolan
approved these changes
Jun 16, 2022
kormide
force-pushed
the
update-example-regression
branch
from
9a4739c to
6b99152
Compare
kormide
force-pushed
the
update-example-regression
branch
from
6b99152 to
23ab3ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last windows regression aside from the
node-gypissue.