-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add repositories.bzl snapshot tests for each lockfile version #2057
Conversation
|
I wish we didn't have so many of these - they are big and brittle, and it's hard to tell whether the changes to these "golden" files are desirable or not. Would it be just as good to test just one of them? |
I explicitly want to see the diff between the pnpm versions and make sure changes to them align. These ones (e2e/pnpm_lockfiles) are easy to update with 1 sh script, it's all just for me to look at the diffs for each version. |
2077cf8
to
c1631a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while the huge amount of goop is annoying, given how pnpm behavior differs between the versions it seems reasonable to have the various goldens. Perhaps the right path forward is to start dropping support for the older versions, v 5.4 was released 5 years ago ;)
Adding the test snapshot files to ensure we see unexpected changes when changing related code.
Changes are visible to end-users: no
Test plan