Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add callout for dependency on generate_bzl_library_targets #1911

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

plobsing
Copy link
Contributor

@plobsing plobsing commented Aug 29, 2024

When this attribute is not set in the call to npm_translate_lock, the queries return no results, the package_json.bzl file is not directly findable, and users may be very confused.


Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:

Manually confirmed the queries work after setting this setting but not before.
See also https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1724827171385349 .

When this attribute is not set in the call to `npm_translate_lock`, the queries return no results, the `package_json.bzl` file is not directly findable, and users may be very confused.
@plobsing plobsing changed the title Add callout for dependency on generate_bzl_library_targets doc: add callout for dependency on generate_bzl_library_targets Aug 29, 2024
Copy link

aspect-workflows bot commented Aug 29, 2024

Test

All tests were cache hits

193 tests (100.0%) were fully cached saving 38s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 1s.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 236ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 839ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 745ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 296ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 112ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 716ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 192ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 713ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 233ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 141ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 171ms.


Buildifier      Format

@alexeagle alexeagle self-requested a review August 29, 2024 13:42
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexeagle alexeagle merged commit ccc4210 into aspect-build:main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants