Use canonical repo name for cross-repo npm_translate_lock
#1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-external-repo-pnpm-lock
branch
from
559c9d8 to
cf17599
Compare
This prevents an error such as the following when trying to run a `js_binary` defined in another module with Bzlmod: ``` ERROR: .../external/rules_pyright~/BUILD:6:23: no such package '@@[unknown repo 'rules_pyright~' requested from @@rules_pyright~]//': The repository '@@[unknown repo 'rules_pyright~' requested from @@rules_pyright~]' could not be resolved: No repository visible as '@rules_pyright~' from repository '@@rules_pyright~' and referenced by '@@rules_pyright~//:pyright__entry_point' ```
fmeum
force-pushed
the
fix-external-repo-pnpm-lock
branch
from
cf17599 to
0c1d9ce
Compare
|
Do you have an example of a failure that you can put in a test? |
|
@jbedard I added a test based on the original reproducer in https://bazelbuild.slack.com/archives/CDCMRLS23/p1722576498988349. |
fmeum
force-pushed
the
fix-external-repo-pnpm-lock
branch
from
37e59e9 to
18fbe17
Compare
fmeum
force-pushed
the
fix-external-repo-pnpm-lock
branch
from
18fbe17 to
bb095d2
Compare
jbedard
reviewed
Aug 2, 2024
jbedard
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an error such as the following when trying to run a
js_binarydefined in another module with Bzlmod:Changes are visible to end-users: yes
Fixed an issue when using
js_binaryfrom another module with Bzlmod.Test plan