fix(npm): npm_link_package() in subdirectory to js_library() package #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
js_lib-link-subdir
branch
4 times, most recently
from
c3311c0 to
79a38ff
Compare
jbedard
force-pushed
the
js_lib-link-subdir
branch
from
79a38ff to
499e484
Compare
jbedard
commented
Jul 26, 2024
jbedard
commented
Jul 26, 2024
gregmagolan
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the
e2e/npm_link_package[-esm]tests, adds a use case within those to test linkingjs_librarypackages.A 3rd e2e test is also added which is the exact same but with the lockfile in a
root/subdir which is where the bug occurs.Changes are visible to end-users: no
Test plan