Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(npm): add test using git+ssh protocol in version #1868

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jul 24, 2024

Changes are visible to end-users: no

Test plan

  • New test cases added

@jbedard jbedard requested a review from JesseTatasciore July 24, 2024 18:02
@jbedard jbedard changed the title 2 attempts at reproducing it - real base/package.json attempt resolves without hte + in it test(npm): add test using git+ssh protocol in version Jul 24, 2024
@jbedard jbedard enabled auto-merge (squash) July 24, 2024 19:08
@jbedard jbedard requested a review from thesayyn July 25, 2024 18:43
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @sahinyortlacework lol

@jbedard jbedard force-pushed the pnpm9-ssh-plus-hash branch from 7162c88 to 4e1c018 Compare July 25, 2024 19:11
@jbedard jbedard merged commit 110dd6d into aspect-build:main Jul 25, 2024
98 checks passed
@jbedard jbedard deleted the pnpm9-ssh-plus-hash branch July 25, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants