fix(npm): expost package_json.bzl and resolved.json for each package alias #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
resolved-aliases
branch
from
2342cfb to
e99aac3
Compare
jbedard
force-pushed
the
resolved-aliases
branch
from
e99aac3 to
ddd8bd8
Compare
jbedard
force-pushed
the
resolved-aliases
branch
2 times, most recently
from
689a604 to
3d627d9
Compare
jbedard
changed the title
jbedard
commented
Jul 20, 2024
jbedard
commented
Jul 20, 2024
jbedard
force-pushed
the
resolved-aliases
branch
from
3d627d9 to
cce48d7
Compare
jbedard
force-pushed
the
resolved-aliases
branch
2 times, most recently
from
fb6697a to
2a0bb84
Compare
jbedard
force-pushed
the
resolved-aliases
branch
from
2a0bb84 to
6748434
Compare
jbedard
force-pushed
the
resolved-aliases
branch
from
6748434 to
34ca7cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different aliases of a package, potentially being different versions, should each have their own
@npm//:pkg-alias/resolved.jsonand@npm//:pkg-alias/package_json.bzl.Previously each alias of a package would write to the same files of the real package name causing a last-write-win and aliases not having these two files.
Changes are visible to end-users: no
Test plan