Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused peer_dependencies field #1826

Merged
merged 1 commit into from
Jun 28, 2024
Merged

refactor: remove unused peer_dependencies field #1826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions npm/private/pnpm.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,12 @@ def _new_import_info(dependencies, dev_dependencies, optional_dependencies):
#
# Metadata may come from different locations depending on the lockfile, this struct should
# have data normalized across lockfiles.
def _new_package_info(id, name, dependencies, optional_dependencies, peer_dependencies, dev, has_bin, optional, requires_build, version, friendly_version, resolution):
def _new_package_info(id, name, dependencies, optional_dependencies, dev, has_bin, optional, requires_build, version, friendly_version, resolution):
return {
"id": id,
"name": name,
"dependencies": dependencies,
"optional_dependencies": optional_dependencies,
"peer_dependencies": peer_dependencies,
"dev": dev,
"has_bin": has_bin,
"optional": optional,
Expand Down Expand Up @@ -188,7 +187,6 @@ def _convert_v5_packages(packages):
version = version,
friendly_version = friendly_version,
dependencies = _convert_pnpm_v5_package_dependency_map(package_snapshot.get("dependencies", {})),
peer_dependencies = _convert_pnpm_v5_package_dependency_map(package_snapshot.get("peerDependencies", {})),
optional_dependencies = _convert_pnpm_v5_package_dependency_map(package_snapshot.get("optionalDependencies", {})),
dev = package_snapshot.get("dev", False),
has_bin = package_snapshot.get("hasBin", False),
Expand Down Expand Up @@ -349,7 +347,6 @@ def _convert_v6_packages(packages):
version = version,
friendly_version = friendly_version,
dependencies = _convert_pnpm_v6_package_dependency_map(package_snapshot.get("dependencies", {})),
peer_dependencies = _convert_pnpm_v6_package_dependency_map(package_snapshot.get("peerDependencies", {})),
optional_dependencies = _convert_pnpm_v6_package_dependency_map(package_snapshot.get("optionalDependencies", {})),
dev = package_snapshot.get("dev", False),
has_bin = package_snapshot.get("hasBin", False),
Expand Down Expand Up @@ -482,7 +479,6 @@ def _convert_v9_packages(packages, snapshots):
friendly_version = friendly_version,
dependencies = _convert_pnpm_v9_package_dependency_map(snapshots, package_snapshot.get("dependencies", {})),
optional_dependencies = _convert_pnpm_v9_package_dependency_map(snapshots, package_snapshot.get("optionalDependencies", {})),
peer_dependencies = package_data.get("peerDependencies", {}),
dev = None, # TODO(pnpm9): must inspect importers.*.devDependencies?
has_bin = package_data.get("hasBin", False),
optional = package_snapshot.get("optional", False),
Expand Down
1 change: 0 additions & 1 deletion npm/private/test/parse_pnpm_lock_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ expected_packages = {
"@aspect-test/d": "2.0.0_at_aspect-test_c_1.0.0",
},
"optional_dependencies": {},
"peer_dependencies": {},
"dev": False,
"has_bin": True,
"optional": False,
Expand Down