Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use .cjs extension for fs patches #1818

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jun 26, 2024

Fix #1756


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested review from gregmagolan and alexeagle June 26, 2024 17:28
@jbedard jbedard marked this pull request as ready for review June 26, 2024 17:28
@jbedard jbedard force-pushed the 1756-patches-cjs branch from 6704635 to 491c518 Compare June 26, 2024 17:33
Copy link

aspect-workflows bot commented Jun 26, 2024

Test

All tests were cache hits

194 tests (100.0%) were fully cached saving 38s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 459ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 534ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 583ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 269ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 574ms.


Test

e2e/pnpm_lockfiles

4 test targets passed

Targets
//v54:aliases-test [k8-fastbuild]594ms
//v60:aliases-test [k8-fastbuild]498ms
//v61:aliases-test [k8-fastbuild]503ms
//v90:aliases-test [k8-fastbuild]208ms

Total test execution time was 2s. 24 tests (85.7%) were fully cached saving 8s.


Test

e2e/pnpm_workspace

3 test targets passed

Targets
//app/a:npm_link_targets_test [k8-fastbuild]552ms
//app/a:test [k8-fastbuild]870ms
//app/b:test [k8-fastbuild]477ms

Total test execution time was 2s. 6 tests (66.7%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 4s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 464ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 460ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 229ms.


Buildifier      Format

@jbedard jbedard force-pushed the 1756-patches-cjs branch from 491c518 to 4d48034 Compare June 26, 2024 18:29
@jbedard jbedard requested a review from thesayyn June 27, 2024 17:15
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@jbedard jbedard force-pushed the 1756-patches-cjs branch from 4d48034 to e56f7e2 Compare June 27, 2024 22:49
@jbedard jbedard enabled auto-merge (squash) June 27, 2024 22:50
@jbedard jbedard merged commit eff595b into aspect-build:main Jun 27, 2024
98 checks passed
@jbedard jbedard deleted the 1756-patches-cjs branch June 27, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: error from aspect_rules_js/js/private/node-patches/register.js with type=module in package.json
2 participants