New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce string concatenation in lockfile parsing #1817

Merged

jbedard merged 1 commit into aspect-build:main from jbedard:pnpm-str-concats

Jun 28, 2024

Member

jbedard commented Jun 26, 2024 •

edited

Loading

Changes are visible to end-users: no

Test plan

Covered by existing test cases

aspect-workflows bot commented Jun 26, 2024 •

edited

Loading

Test

All tests were cache hits

194 tests (100.0%) were fully cached saving 37s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 459ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 534ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 583ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 269ms.

Test

e2e/npm_translate_package_lock

Buildkite build #4927 is running...

Test

e2e/npm_translate_yarn_lock

Buildkite build #4927 is running...

Test

e2e/package_json_module

Buildkite build #4927 is running...

Test

e2e/pnpm_lockfiles

Buildkite build #4927 is running...

Test

e2e/pnpm_workspace

Buildkite build #4927 is running...

Test

e2e/pnpm_workspace_rerooted

Buildkite build #4927 is running...

Test

e2e/repo_mapping

Buildkite build #4927 is running...

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 460ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 229ms.

Buildifier Format

jbedard force-pushed the pnpm-str-concats branch from 5410d93 to 2488077 Compare

June 26, 2024 20:31

jbedard requested review from gregmagolan and thesayyn

June 27, 2024 04:01

jbedard marked this pull request as ready for review

June 27, 2024 04:01


          perf: reduce string concatenation in lockfile parsing

e17026a

jbedard force-pushed the pnpm-str-concats branch from 2488077 to e17026a Compare

June 28, 2024 00:09

thesayyn approved these changes

View reviewed changes

jbedard merged commit d394cf2 into aspect-build:main

98 checks passed

jbedard deleted the pnpm-str-concats branch

June 28, 2024 18:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet