Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce use of bazel_skylib paths.join #1812

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jun 20, 2024

In most scenarios we don't need all the logic detecting empty segments or detecting absolute paths in individual parts.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Jun 20, 2024

Test

3 test targets passed

Targets
//npm/private/test:bin_test [k8-fastbuild]                     2s
//npm/private:_test_gendocs_0_0 [k8-fastbuild]                 210ms
//npm/private:_test_gendocs_0_1 [k8-fastbuild]                 181ms

Total test execution time was 2s. 190 tests (98.4%) were fully cached saving 37s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 486ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 557ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 923ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 251ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 566ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

28 tests (100.0%) were fully cached saving 10s.


Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 3s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 453ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 605ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.


Buildifier      Format

@jbedard jbedard marked this pull request as ready for review June 20, 2024 17:25
@jbedard jbedard requested review from gregmagolan and alexeagle June 20, 2024 17:25
@jbedard jbedard merged commit c802f21 into aspect-build:main Jun 20, 2024
98 checks passed
@jbedard jbedard deleted the no-mo-path_join branch June 20, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants