-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize _is_gnu_tar check #1807
Merged
jbedard
merged 4 commits into
aspect-build:main
from
DavidZbarsky-at:zbarsky/is-gnu-tar
Jun 18, 2024
Merged
Optimize _is_gnu_tar check #1807
jbedard
merged 4 commits into
aspect-build:main
from
DavidZbarsky-at:zbarsky/is-gnu-tar
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidZbarsky-at
force-pushed
the
zbarsky/is-gnu-tar
branch
from
June 14, 2024 03:39
ca0de70
to
437d2ee
Compare
jbedard
reviewed
Jun 14, 2024
jbedard
reviewed
Jun 14, 2024
DavidZbarsky-at
force-pushed
the
zbarsky/is-gnu-tar
branch
3 times, most recently
from
June 17, 2024 21:55
acdede7
to
f7789f3
Compare
jbedard
approved these changes
Jun 17, 2024
DavidZbarsky-at
force-pushed
the
zbarsky/is-gnu-tar
branch
from
June 17, 2024 21:59
f7789f3
to
2319568
Compare
DavidZbarsky-at
force-pushed
the
zbarsky/is-gnu-tar
branch
from
June 17, 2024 22:00
2319568
to
a82b6c1
Compare
jbedard
reviewed
Jun 18, 2024
DavidZbarsky-at
force-pushed
the
zbarsky/is-gnu-tar
branch
3 times, most recently
from
June 18, 2024 03:21
c951f9c
to
9ec0a40
Compare
DavidZbarsky-at
force-pushed
the
zbarsky/is-gnu-tar
branch
from
June 18, 2024 03:41
9ec0a40
to
af003fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
I have another version of this PR switching to the hermetic bsdtar toolchain (basically resolving it in the repo rule/module extension and passing it down in the same way), but this seems safer for now.
I also threw in some minor optimizations along the way while I was in the code.
Changes are visible to end-users: no
Test plan
- Covered by existing test cases