refactor(pnpm): move pnpm parsing logic to pnpm.bzl #1777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this worth loosing the
git blame
history on all this code? Theutils.bzl
is getting getting pretty big and I keep thinking this stuff should live on its own...Some of the moved code was reordered to group things by pnpm lockfile version a bit better, I think I added
_v5
to one method name to highlight that it's only for v5 lockfiles, otherwise the moved code is unchanged.Changes are visible to end-users:no
Test plan