Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnpm): pnpm9 transitive npm: dependenies #1775

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jun 3, 2024

This is for transitive npm: dependencies, previously we only handled direct npm: deps with v9.


Changes are visible to end-users: no

Test plan

  • New test cases added

@jbedard jbedard requested a review from gregmagolan June 3, 2024 18:04
@jbedard jbedard force-pushed the pnpm9-transitive-alias branch from b25ddaf to af3b088 Compare June 3, 2024 18:05
Copy link

aspect-workflows bot commented Jun 3, 2024

Test

All tests were cache hits

193 tests (100.0%) were fully cached saving 52s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 439ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 923ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 520ms.


Test

e2e/pnpm_lockfiles

12 test targets passed

Targets
//v54:aliases-test [k8-fastbuild]584ms
//v54:repos_0_test [k8-fastbuild]442ms
//v54:targets [k8-fastbuild]176ms
//v60:aliases-test [k8-fastbuild]614ms
//v60:repos_0_test [k8-fastbuild]411ms
//v60:targets [k8-fastbuild]70ms
//v61:aliases-test [k8-fastbuild]438ms
//v61:repos_0_test [k8-fastbuild]438ms
//v61:targets [k8-fastbuild]135ms
//v90:aliases-test [k8-fastbuild]319ms
//v90:repos_0_test [k8-fastbuild]524ms
//v90:targets [k8-fastbuild]144ms

Total test execution time was 4s. 15 tests (55.6%) were fully cached saving 5s.


Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 605ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.


Buildifier      Format

@jbedard jbedard force-pushed the pnpm9-transitive-alias branch from af3b088 to df07584 Compare June 3, 2024 18:47
@jbedard jbedard force-pushed the pnpm9-transitive-alias branch from df07584 to f4cf334 Compare June 3, 2024 18:48
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠

@jbedard jbedard merged commit 3e08f8e into aspect-build:main Jun 3, 2024
98 checks passed
@jbedard jbedard deleted the pnpm9-transitive-alias branch June 3, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants