Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pnpm workspace dep on a 1p package #170

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Use pnpm workspace dep on a 1p package #170

merged 1 commit into from
Jun 20, 2022

Conversation

alexeagle
Copy link
Member

No description provided.

@alexeagle
Copy link
Member Author

hmm, locally on Ubuntu 20 this fails for me:

$ bazel test ...
ERROR: /home/alexeagle/Projects/rules_js/examples/npm_deps/BUILD.bazel:20:22: Label '//examples/npm_deps:node_modules/@mycorp/mylib/dir' is invalid because 'examples/npm_deps/node_modules/@mycorp/mylib' is a subpackage; perhaps you meant to put the colon here: '//examples/npm_deps/node_modules/@mycorp/mylib:dir'?
ERROR: package contains errors: examples/npm_deps

@gregmagolan gregmagolan self-requested a review June 20, 2022 18:45
@gregmagolan gregmagolan marked this pull request as ready for review June 20, 2022 18:46
gregmagolan
gregmagolan approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@gregmagolan gregmagolan merged commit 9a48825 into main Jun 20, 2022
@gregmagolan gregmagolan deleted the link_issue branch February 22, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees

@gregmagolan gregmagolan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @gregmagolan