perf: change js_helpers gather_* utils to accept list, not depset

js/private/js_binary.bzl

@@ -525,7 +525,7 @@ def _create_launcher(ctx, log_prefix_rule_set, log_prefix_rule, fixed_args = [],
 
     runfiles = gather_runfiles(
         ctx = ctx,
-        sources = [],
+        sources = depset(),
         data = ctx.attr.data,
         data_files = [entry_point] + ctx.files.data,
         deps = [],

js/private/js_helpers.bzl

@@ -8,39 +8,35 @@ def gather_transitive_sources(sources, targets):
     """Gathers transitive sources from a list of direct sources and targets
 
     Args:
-        sources: list or depset of direct sources which should be included in `transitive_sources`
+        sources: list of direct sources which should be included in `transitive_sources`
         targets: list of targets to gather `transitive_sources` from `JsInfo`
 
     Returns:
         A depset of transitive sources
     """
-    if type(sources) == "list":
-        sources = depset(sources)
     transitive = [
         target[JsInfo].transitive_sources
         for target in targets
         if JsInfo in target and hasattr(target[JsInfo], "transitive_sources")
     ]
-    return depset([], transitive = [sources] + transitive)
+    return depset(sources, transitive = transitive)
 
 def gather_transitive_types(types, targets):
     """Gathers transitive types from a list of direct types and targets
 
     Args:
-        types: list or depset of direct sources which should be included in `transitive_types`
+        types: list of direct sources which should be included in `transitive_types`
         targets: list of targets to gather `transitive_types` from `JsInfo`
 
     Returns:
         A depset of transitive sources
     """
-    if type(types) == "list":
-        types = depset(types)
     transitive = [
         target[JsInfo].transitive_types
         for target in targets
         if JsInfo in target and hasattr(target[JsInfo], "transitive_types")
     ]
-    return depset([], transitive = [types] + transitive)
+    return depset(types, transitive = transitive)
 
 def gather_npm_sources(srcs, deps):
     """Gathers npm sources from a list of srcs and deps targets
@@ -138,7 +134,7 @@ def gather_runfiles(
     Args:
         ctx: the rule context
 
-        sources: list or depset of files which should be included in runfiles
+        sources: depset which should be included in runfiles
 
         deps: list of dependency targets; only transitive runfiles are gather from these targets
 
@@ -177,8 +173,6 @@ def gather_runfiles(
     """
 
     # Includes sources
-    if type(sources) == "list":
-        sources = depset(sources)
     transitive_files_depsets = [sources]
 
     # Gather the default outputs of data targets