perf: do not include sources,types when transitive_sources,type alrea…

…dy included (#1803)
aspect-build · Jun 19, 2024 · 3589e16 · 3589e16
1 parent 98081d0
commit 3589e16
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/js/private/js_helpers.bzl b/js/private/js_helpers.bzl
@@ -275,14 +275,17 @@ def gather_files_from_js_infos(
     for target in targets:
         if JsInfo in target:
             js_info = target[JsInfo]
-            if include_sources:
-                files_depsets.append(js_info.sources)
-            if include_types:
-                files_depsets.append(js_info.types)
+
             if include_transitive_sources:
                 files_depsets.append(js_info.transitive_sources)
+            elif include_sources:
+                files_depsets.append(js_info.sources)
+
             if include_transitive_types:
                 files_depsets.append(js_info.transitive_types)
+            elif include_types:
+                files_depsets.append(js_info.types)
+
             if include_npm_sources:
                 files_depsets.append(js_info.npm_sources)