refactor: drop support for Bazel 5 (#1589)

aspect-build · Apr 20, 2024 · 23f6aec · 23f6aec
1 parent 1c4c94d
commit 23f6aec
Show file tree

Hide file tree

Showing 55 changed files with 675 additions and 4,874 deletions.
diff --git a/.prettierignore b/.prettierignore
@@ -4,7 +4,6 @@ e2e/**/*-docs.md
 examples/**/*-docs.md
 js/private/coverage/coverage.js
 js/private/node-patches/fs.js
-js/private/node-patches_legacy/fs.js
 min/
 npm/private/test/vendored/
 js/private/worker/worker.js

diff --git a/docs/js_binary.md b/docs/js_binary.md
diff --git a/e2e/gyp_no_install_script/snapshots/bzlmod/repositories.bzl b/e2e/gyp_no_install_script/snapshots/bzlmod/repositories.bzl
diff --git a/e2e/gyp_no_install_script/snapshots/bzlmod/segfault-handler_defs.bzl b/e2e/gyp_no_install_script/snapshots/bzlmod/segfault-handler_defs.bzl
diff --git a/e2e/npm_translate_lock/snapshots/bzlmod/repositories.bzl b/e2e/npm_translate_lock/snapshots/bzlmod/repositories.bzl
diff --git a/e2e/npm_translate_lock/snapshots/wksp/repositories.bzl b/e2e/npm_translate_lock/snapshots/wksp/repositories.bzl
diff --git a/e2e/npm_translate_lock_empty/snapshots/bzlmod/repositories.bzl b/e2e/npm_translate_lock_empty/snapshots/bzlmod/repositories.bzl
diff --git a/e2e/npm_translate_lock_empty/snapshots/wksp/repositories.bzl b/e2e/npm_translate_lock_empty/snapshots/wksp/repositories.bzl
diff --git a/js/BUILD.bazel b/js/BUILD.bazel
@@ -1,20 +1,13 @@
 "Public API"
 
 load("@aspect_bazel_lib//lib:utils.bzl", "is_bazel_7_or_greater")
-load("@bazel_features//:features.bzl", "bazel_features")
 load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 exports_files(
     glob(["*.bzl"]),
     visibility = ["//docs:__pkg__"],
 )
 
-config_setting(
-    name = "allow_unresolved_symlinks",
-    values = {bazel_features.flags.allow_unresolved_symlinks: "true"},
-    visibility = ["//visibility:public"],
-)
-
 config_setting(
     name = "enable_runfiles",
     values = {"enable_runfiles": "true"},

diff --git a/js/defs.bzl b/js/defs.bzl
@@ -32,10 +32,6 @@ def js_binary(**kwargs):
             Label("@aspect_rules_js//js:enable_runfiles"): True,
             "//conditions:default": False,
         }),
-        unresolved_symlinks_enabled = select({
-            Label("@aspect_rules_js//js:allow_unresolved_symlinks"): True,
-            "//conditions:default": False,
-        }),
         **kwargs
     )
 
@@ -45,10 +41,6 @@ def js_test(**kwargs):
             Label("@aspect_rules_js//js:enable_runfiles"): True,
             "//conditions:default": False,
         }),
-        unresolved_symlinks_enabled = select({
-            Label("@aspect_rules_js//js:allow_unresolved_symlinks"): True,
-            "//conditions:default": False,
-        }),
         **kwargs
     )