Include the LICENSE file in the sdist #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the preferred way to do this is to add [metadata]
license_file = LICENSEto |
|
@sloria thanks for the tip, that's indeed better. Updated. 👍 |
nicoddemus
force-pushed
the
include-license-in-sdist
branch
from
9d3637f
to
371005c
Compare
|
I wonder if we shouldn't just make setuptools do this by default (doesn't it already?) |
sloria
added a commit
to sloria/pyupgrade
that referenced
this pull request
Jan 31, 2019
Turns out asottile#90 only adds LICENSE to the wheel. This ensures that LICENSE and README.md are also in the sdist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙃