Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Added getOrder for btc-markets exchange #936

Closed
wants to merge 1 commit into from

Conversation

upsatish
Copy link

@upsatish upsatish commented Aug 8, 2017

Fixes #935

@askmike
Copy link
Owner

askmike commented Aug 8, 2017

Hey @anotherkabab,

Some context: Since 0.5 the trader was updated and it now requires two changes:

I've failed to do this for all exchanges, so some (including btc-markets) are now outdated. We would need to fix both issues above before we can add it back!

@upsatish
Copy link
Author

upsatish commented Aug 9, 2017

Hi @askmike thank you for the review. I'll do those changes as you suggested.

Is there any way to test this apart from running the trader live?

@askmike
Copy link
Owner

askmike commented Aug 9, 2017

I haven't found any, since it's all about dealing with real response data from the exchange. Some exchanges provide a sandbox API, if btc-markets does this that would be an option.

@askmike
Copy link
Owner

askmike commented Sep 30, 2017

Closing this for inactivity.

@upsatish
Copy link
Author

Sorry, wasn't able to complete this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants