Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Fix to importer dates #2566

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Fix to importer dates #2566

merged 1 commit into from
Sep 30, 2018

Conversation

rkingy
Copy link
Contributor

@rkingy rkingy commented Sep 28, 2018

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix date issues in importer.
#2563 (comment)

  • What is the current behavior? (You can also link to an open issue here)

Dates from the GUI are wrong..

  • What is the new behavior (if this is a feature change)?

Everything works as expected again in UTC format.

  • Other information:

@mark-sch
Copy link
Contributor

It is some time ago, but I remember similar import issues when dealing with PostgreSQL db. To get it working there had been some moment and utc changes necessary. Which db are you using? Maybe it needs deeper testing with different db environments...

@rkingy
Copy link
Contributor Author

rkingy commented Sep 28, 2018

Hi @mark-sch I'm just using the standard install. I believe it uses "sqlite3": "^4.0.0",
This has only been an issue I've noticed since upgrading a fresh install to the latest 0.6.6 version. I had been using the older version for quite a long time.

Your probably right if people are using different dbs that handle dates differently. But for those that clone the repo and run for the first time it also needs to work out of the box.

Without the .utc treatment this is what the GUI looks like when doing a import. Starts off in negative % bar and then never imports up to the date you want.

screenshot 2018-09-29 11 43 37
screenshot 2018-09-29 11 43 42

@askmike
Copy link
Owner

askmike commented Sep 29, 2018

@rkingy @mark-sch thanks for providing a fix and context. I will test this with both sqlite and postgres asap.

@askmike
Copy link
Owner

askmike commented Sep 30, 2018

this PR fixes the importer using both databases for me. I am currently in UTC+8 and I definitely noticed the offset, I think always. With this PR the problem goes away for me.

@mark-sch if you encounter problems after this PR please let me know!

@askmike askmike merged commit b57b44e into askmike:develop Sep 30, 2018
This was referenced Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants