v0.6 support for bitx (aka Luno) #2335
Conversation
exchange/wrappers/bitx.js
Outdated
| const BitX = require("bitx"); | ||
| const _ = require('lodash'); | ||
| const moment = require('moment'); | ||
| const log = require('../../core/log'); |
There was a problem hiding this comment.
can you not import anything from outside the exchange folder? That way people can use Gekko Broker as a standalone lib. Thanks!
There was a problem hiding this comment.
Alright... i'll push an update later.
Curious, how do you plan to handle logging for exchanges moving forward?
|
Woa great PR Thanks a lot! Just one small nit, see comment :) Side note: did this take you very long and where the docs very clear? |
|
I didnt depend on the docs much, just did an quick diff of the docs and mainly "diff-ing" the new binance + polonex exchanges. Oh yes, this reminds me, I had to add in roundAmount and roundPrice. This wasnt documented. |
|
Seems to work great! |
|
TODO Follow up (I will pick those up, unless you want to do another PR):
|
|
Sure.. that seems simple enough :) |
Update exchange for v0.6.