This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
GDAX Fix from #1808 #1818
Merged
GDAX Fix from #1808 #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thanks, wasn't in a position to send a PR last night. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix
What is the current behavior? (You can also link to an open issue here)
Return in cancel order not handled correctly.
What is the new behavior (if this is a feature change)?
Fixed callback returns as per @cmroche comment in GDAX cancelOrder fix and misc other fixes #1808
Other information:
@askimike / @cmroche this is a minor PR to fix a change introduced in the already merged GDAX cancelOrder fix and misc other fixes #1808, if you can merge this I'd appreciate it.