Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle compressed fits files #694

Merged
merged 30 commits into from
Dec 12, 2023
Merged

Correctly handle compressed fits files #694

merged 30 commits into from
Dec 12, 2023

Conversation

ddobie
Copy link
Contributor

@ddobie ddobie commented Jul 31, 2023

Fix #693.

@ddobie ddobie requested a review from ajstewart July 31, 2023 00:27
@ddobie
Copy link
Contributor Author

ddobie commented Jul 31, 2023

@ajstewart would be good to get your eyes on this before I go further and update docs etc

@ajstewart
Copy link
Contributor

This seems ok to me so far!

@ddobie ddobie marked this pull request as ready for review December 8, 2023 01:31
@ddobie ddobie requested a review from ajstewart December 8, 2023 01:32
@ddobie
Copy link
Contributor Author

ddobie commented Dec 8, 2023

I think this is good to go. I haven't added any tests for the open_fits function because there aren't any for the rest of the utils functions. If it's broken then almost every other test should fail (which was happening earlier this morning) so it's probably fine. Happy to add tests if you think it's necessary though.

ajstewart
ajstewart approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though I'm a bit confused at what this is supporting given the doc edit.

On the tests, yeah there aren't any tests as we never got around to it. If it's a small test then it's good to start adding them. But I'm not fussed.

.github/workflows/test-suite.yml Show resolved Hide resolved
docs/using/runconfig.md Show resolved Hide resolved
@ddobie ddobie merged commit 6209e0d into dev Dec 12, 2023
4 checks passed
@ddobie ddobie deleted the iss693-handle-compressed-fits branch December 12, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajstewart ajstewart ajstewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pipeline Backlog
Status: Done
Roadmap to having full data available and processed through VAST pipeline
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable use of .fits.fz files
2 participants
@ddobie @ajstewart