add sql limitation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbashus
reviewed
May 13, 2020
| ## Join doesn't support aggregation on Joined result. | ||
| The Join doesn't support aggregation on the joined result. e.g. `SELECT depo.name, avg(empo.age) FROM empo JOIN depo WHERE empo.id == depo.id GROUP BY depo.name` is not supported. [Issue 110](https://github.com/opendistro-for-elasticsearch/sql/issues/110). | ||
|
|
||
| ## Pagination |
There was a problem hiding this comment.
Can we change this to Cursor, we are using that elsewhere.
abbashus
reviewed
May 13, 2020
| The Join doesn't support aggregation on the joined result. e.g. `SELECT depo.name, avg(empo.age) FROM empo JOIN depo WHERE empo.id == depo.id GROUP BY depo.name` is not supported. [Issue 110](https://github.com/opendistro-for-elasticsearch/sql/issues/110). | ||
|
|
||
| ## Pagination | ||
| The pagination query enable user to get the paginated respones. Currently, the pagination only support basic query. e.g. The following query will return the data with cursor id. |
anirudha
suggested changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add SQL Limitation section.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.