Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spanish translation #183

Merged
merged 3 commits into from
May 27, 2020
Merged

Added Spanish translation #183

merged 3 commits into from
May 27, 2020

Conversation

julianrrr
Copy link
Contributor

Changes

Added a Spanish translation files, F-Droid/Play Store metadata and edited the credit file according to the instructions.

Testing

  • Tested on a physical device

@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented May 27, 2020

Ignore if build 732.3 fails. It wasn't supposed to run.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #183 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
+ Coverage     81.72%   81.80%   +0.08%     
  Complexity      134      134              
============================================
  Files            12       12              
  Lines           859      863       +4     
  Branches         87       87              
============================================
+ Hits            702      706       +4     
  Misses           92       92              
  Partials         65       65              
Impacted Files Coverage Δ Complexity Δ
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 99.32% <100.00%> (+0.01%) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cf1b3...e3c9606. Read the comment docs.

@ashutoshgngwr ashutoshgngwr changed the base branch from 0.7.x to master May 27, 2020 16:58
Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @julianrrr. I really appreciate you taking the time to generate all the image assets. It just needs a single change.

fastlane/metadata/android/es-ES/short_description.txt Outdated Show resolved Hide resolved
@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented May 27, 2020

Wow. Sometimes my actions do lead to a mess. @julianrrr

If you see this message, I'll take it from here. Merging master into your forks 0.7.x caused some more issues I think.
https://github.com/ashutoshgngwr/noice/blob/9b16581b0dcd2ff500628f783e59e743c2251cc8/app/src/main/java/com/github/ashutoshgngwr/noice/fragment/AboutFragment.kt#L153

Please leave it be for the time being. I see you have committed the change I requested. I'll fix this from my end. Sorry for the mess.

Edit: Please make sure that you have "Allow edits from Maintainers" option enabled on the PR.

@julianrrr
Copy link
Contributor Author

Wow. Sometimes my actions do lead to a mess. @julianrrr

If you see this message, I'll take it from here. Merging master into your forks 0.7.x caused some more issues I think.

https://github.com/ashutoshgngwr/noice/blob/9b16581b0dcd2ff500628f783e59e743c2251cc8/app/src/main/java/com/github/ashutoshgngwr/noice/fragment/AboutFragment.kt#L153

Please leave it be for the time being. I see you have committed the change I requested. I'll fix this from my end. Sorry for the mess.

Edit: Please make sure that you have "Allow edits from Maintainers" option enabled on the PR.

Ok, the option is enable. Tell me if anymore need to be adjusted

@ashutoshgngwr
Copy link
Member

@julianrrr can you please verify if everything is as you intended it to be?

@ashutoshgngwr
Copy link
Member

This looks fine to me. I'll go ahead and merge this. Still let me know if anything is not okay.

@ashutoshgngwr ashutoshgngwr merged commit 41d00fe into trynoice:master May 27, 2020
@ashutoshgngwr ashutoshgngwr added this to the 0.8.x milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants