Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-rBR translation #166

Merged
merged 10 commits into from
May 20, 2020
Merged

pt-rBR translation #166

merged 10 commits into from
May 20, 2020

Conversation

CebolaBros64
Copy link
Contributor

@CebolaBros64 CebolaBros64 commented May 16, 2020

Changes

Translated the app's strings and Play Store metadata.

Testing

  • Tested on a physical device

Others

Neither screenshots nor featureGraphic image were added to the regional Play Store metadata
Tag #108

@ashutoshgngwr
Copy link
Member

@CebolaBros64 Ignore travis builds. Those seem to be failing due to an unrelated issue.

@ashutoshgngwr ashutoshgngwr added this to the 0.8.x milestone May 16, 2020
Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CebolaBros64 I haven't reverse translated the changes to verify the correctness yet but the changes look positive from developers purview. I have to hold off on merging this because recently I've been trying to follow strict SemVer. Since 0.7.1 is planned before 0.8.x, I have to hold off on the features. I should be able to merge this next week. I'll reach out if I have any follow ups.

@ashutoshgngwr ashutoshgngwr force-pushed the master branch 2 times, most recently from 06575ac to 6d31fda Compare May 18, 2020 07:14
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     81.52%   81.52%           
  Complexity      130      130           
=========================================
  Files            12       12           
  Lines           850      850           
  Branches         86       86           
=========================================
  Hits            693      693           
  Misses           92       92           
  Partials         65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf827c3...942c5a9. Read the comment docs.

@ashutoshgngwr ashutoshgngwr changed the base branch from master to fix/appearance/dark-theme May 18, 2020 08:43
@ashutoshgngwr ashutoshgngwr changed the base branch from fix/appearance/dark-theme to master May 18, 2020 08:43
Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CebolaBros64 Can you please make the suggested change. Also, I need clarification on the first two comments. Everything else is neat. This is great work. 👍

app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
Copy link

@rffontenelle rffontenelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there. Brazilian here. I made a few more suggestions below for your consideration.

app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
fastlane/metadata/android/pt-BR/full_description.txt Outdated Show resolved Hide resolved
Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Thanks for the contributions @CebolaBros64 @rffontenelle

@CebolaBros64 I'll merge this once I add the feature graphic and screenshots. There's nothing more you need to do from your end.

Copy link

@rffontenelle rffontenelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. Thanks @CebolaBros64 the initiative to translate and @ashutoshgngwr for the attention and, of course, this awesome software :)

@ashutoshgngwr ashutoshgngwr merged commit a22890f into trynoice:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants