-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pt-rBR translation #166
pt-rBR translation #166
Conversation
@CebolaBros64 Ignore travis builds. Those seem to be failing due to an unrelated issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CebolaBros64 I haven't reverse translated the changes to verify the correctness yet but the changes look positive from developers purview. I have to hold off on merging this because recently I've been trying to follow strict SemVer. Since 0.7.1 is planned before 0.8.x, I have to hold off on the features. I should be able to merge this next week. I'll reach out if I have any follow ups.
06575ac
to
6d31fda
Compare
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=========================================
Coverage 81.52% 81.52%
Complexity 130 130
=========================================
Files 12 12
Lines 850 850
Branches 86 86
=========================================
Hits 693 693
Misses 92 92
Partials 65 65 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CebolaBros64 Can you please make the suggested change. Also, I need clarification on the first two comments. Everything else is neat. This is great work. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there. Brazilian here. I made a few more suggestions below for your consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Thanks for the contributions @CebolaBros64 @rffontenelle
@CebolaBros64 I'll merge this once I add the feature graphic and screenshots. There's nothing more you need to do from your end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too. Thanks @CebolaBros64 the initiative to translate and @ashutoshgngwr for the attention and, of course, this awesome software :)
Changes
Translated the app's strings and Play Store metadata.
Testing
Others
Neither screenshots nor featureGraphic image were added to the regional Play Store metadata
Tag #108