Fix view height used for menu positioning (JedWatson#5177)

* Fix view height used for menu positioning * Create friendly-icons-flow.md * Format * Reset yarn.lock
ashu8912 · May 7, 2022 · 1f140e4 · 1f140e4
1 parent c963633
commit 1f140e4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/friendly-icons-flow.md b/.changeset/friendly-icons-flow.md
@@ -0,0 +1,5 @@
+---
+'react-select': patch
+---
+
+Fix view height used for menu positioning to be the scroll parent instead of the window
diff --git a/packages/react-select/src/components/Menu.tsx b/packages/react-select/src/components/Menu.tsx
@@ -12,9 +12,10 @@ import { createPortal } from 'react-dom';
 import {
   animatedScrollTo,
   getBoundingClientObj,
-  RectType,
   getScrollParent,
   getScrollTop,
+  normalizedHeight,
+  RectType,
   scrollTo,
 } from '../utils';
 import {
@@ -75,7 +76,9 @@ export function getMenuPlacement({
   } = menuEl.getBoundingClientRect();
 
   const { top: containerTop } = menuEl.offsetParent.getBoundingClientRect();
-  const viewHeight = window.innerHeight;
+  const viewHeight = isFixedPosition
+    ? window.innerHeight
+    : normalizedHeight(scrollParent);
   const scrollTop = getScrollTop(scrollParent);
 
   const marginBottom = parseInt(getComputedStyle(menuEl).marginBottom, 10);