-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FSharp.Compiler.Service to version 34.0.1 #112
Conversation
I'm not sure how support for LangVersion would flow through sharplab specifically, though. Another thing I noticed: it looks like in sharplab the F# support is using .Net Framework instead of .Net Core assemblies? If that's right I can help fix that. |
Thanks! Looks good -- I'll take a look soon. For SharpLab:
|
LangVersion should probably just be 'preview' for us, then. This includes all present and future language enhancements. Re: .Net Core/.Net Framework: there's a |
# Conflicts: # Tests.NetCore/Tests.NetCore.csproj # Tests.Shared/FSharpProjectOptionsExtensionsTests.cs
Thanks -- do you want to include |
I went ahead and added it. The valid values are (taken from the F# compiler codebase): // Indicates we assume "mscorlib.dll", i.e .NET Framework, Mono and Profile 47
| "mscorlib" -> PrimaryAssembly.Mscorlib
// Indicates we assume "System.Runtime.dll", i.e .NET Standard 1.x, .NET Core App 1.x and above, and Profile 7/78/259
| "netcore" -> PrimaryAssembly.System_Runtime
// Indicates we assume "netstandard.dll", i.e .NET Standard 2.0 and above
| "netstandard" -> PrimaryAssembly.NetStandard but all code in the compiler uses one of "mscorlib" or "netcore", so for SharpLab that seems a reasonable path to follow. |
I wonder if we want to provide string constants for those, but anyways can always add later. |
Is there any way to set the TargetProfile for normal CSharp compilation? I can't seem to find that option. |
This brings along some perf improvements, as well as a slew of syntax features and preview features that have been merged in the last few months.
I added support for the LangVersion option to the MirrorSharpFsharpOptions as well, which enables people to use any of the features gated by specific language version/preview support: feature list