This repository has been archived by the owner on Jan 7, 2018. It is now read-only.
Simplify implementation using blocks #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for ad-hoc change dictionaries and such.
Fixes #13
|
This worked brilliantly for me under iOS 8 & 9. Thanks for the fixes, @nolanw! |
|
This also fixed my issues with FRC and UICollectionView, have been using a variation on Ash's original implementation and had many issues in iOS9.3. I ported this to Swift and it resolves all issues I was having including double free errors. Came across this when I realised that the blocks were being executed on background threads. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for ad-hoc change dictionaries and such. Fixes #13
I deleted the code purporting to fix Apple bug 12954582 as it didn't seem particularly relevant to the aim of the repo as stated in the README and muddied the example. (It was also a convenient excuse to not figure out the contortions needed to port the bug workaround over to this blocks-based implementation.)
Moreover, using
NSBlockOperationdid not seem like a good fit. Using it simply as an array of blocks offers no obvious benefits over, well, a simple array of blocks. Plus it's not guaranteed to execute on the main thread.