Stop installing application icons to the legacy pixmaps location #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian officially deprecated the old Debian menu system more than 5 years ago [1]. Hence, drop the old menu file, as not much of use anymore. [1] https://lists.debian.org/debian-devel-announce/2015/09/msg00000.html
The application icon is already provided as PNG in different sizes, and installed in the global XDG hicolor icon theme. Hence, the XPM version of it can be dropped, as it is redundant.
The /usr/share/pixmaps location is considered a legacy location for application icons; since the application icons are already installed in the global XDG hicolor theme, then simply stop installing the 48px one in the legacy pixmaps location.
|
Thanks, merged. We no longer need to support these old systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/usr/share/pixmapslocation is considered a legacy location for application icons; since the application icons are already installed in the global XDG hicolor theme, then:As related change, drop the old Debian menu file, no more needed (see [1]), and it references the removed XPM icon.
[1] https://lists.debian.org/debian-devel-announce/2015/09/msg00000.html