Set LC_ALL to control the locale #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LANG specifies the default locale, LC_NUMERIC specifies the locale for that particular category, but LC_ALL overrides all the locale settings. Thus any user with LC_ALL set can still run into locale-related problems. Setting LC_ALL to C avoids any such issue. See locale(7) for details. Signed-off-by: Stephen Kitt <steve@sk2.org>
|
Hello, Thanks a lot for the patch. Indeed, Linux locale(7) states this behavior. I dug a bit deeper and it seems to come from POSIX, with FreeBSD, Darwin, and Solaris having the same behavior. I have not found a way to force LC_NUMERIC on Windows yet, but a future JSON output parser will solve this anyway, at least when invoking smartctl. Thanks! |
|
Ah yes, I should have provided the POSIX reference — https://pubs.opengroup.org/onlinepubs/9699919799/utilities/locale.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LANG specifies the default locale, LC_NUMERIC specifies the locale for
that particular category, but LC_ALL overrides all the locale
settings. Thus any user with LC_ALL set can still run into
locale-related problems.
Setting LC_ALL to C avoids any such issue.
See locale(7) for details.
Signed-off-by: Stephen Kitt steve@sk2.org