Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsmartcontrol 1.1.3 windows 64 fails to run from command line (title edited) #20

Closed
TonyApuzzo opened this issue Nov 29, 2021 · 2 comments
Labels
bug Something isn't working fixed The issue has been fixed windows Windows-related issue

Comments

@TonyApuzzo
Copy link

When I run gsmartcontrol from an unzipped folder, it fails, however, if I run it from an installed version using the .exe installer, then it works. Note that the problem appears to be more related to smartctl-nc.exe than to gsmartcontrol itself. smartctl-nc.exe -V displays nothing which is why the gsmartcontrol launcher is failing immediately.

Is there more to running gsmartcontrol via the unzipped archive than just unzipping and running the command? I get the following behavior when running from an unzipped folder:

image

Command Line log:

PS C:\Users\tonya\Downloads\gsmartcontrol-1.1.3-win64> .\gsmartcontrol.exe
PS C:\Users\tonya\Downloads\gsmartcontrol-1.1.3-win64>
PS C:\Users\tonya\Downloads\gsmartcontrol-1.1.3-win64>
<dump>  [app]   locale: 1
<dump>  [app]   version: 0
<dump>  [app]   hide_tabs: 1
<dump>  [app]   scan: 1
<dump>  [app]   arg_add_virtual: [empty]
<dump>  [app]   arg_add_device: [empty]
<dump>  [app]   arg_gdk_scale: nan
<dump>  [app]   arg_gdk_dpi_scale: nan
<dump>  [app] LibDebug options:
<dump>  [app]   levels_enabled: 11111
<dump>  [app]   debug_colorize: false
<dump>  [app] {anonymous}::app_init_config(): Global config file: "gsmartcontrol.conf"
<dump>  [app] {anonymous}::app_init_config(): Local config file: "C:\Users\tonya\AppData\Roaming\gsmartcontrol\gsmartcontrol.conf"
<dump>  [app] {anonymous}::app_init_config(): Old local config file: "C:\Users\tonya\Documents\gsmartcontrol.conf"
<info>  [rmn] Loading under "/config" from file "C:\Users\tonya\AppData\Roaming\gsmartcontrol\gsmartcontrol.conf".
<dump>  [rconfig] /                    [3] /
config               [4] /config
gui                  [3] /config/gui
main_window          [3] /config/gui/main_window
default_size_w       [3] /config/gui/main_window/default_size_w 560
default_size_h       [3] /config/gui/main_window/default_size_h 779
default_pos_x        [3] /config/gui/main_window/default_pos_x 234
default_pos_y        [3] /config/gui/main_window/default_pos_y 234
default              [4] /default
<info>  [rconfig] Setting autosave config file to "C:\Users\tonya\AppData\Roaming\gsmartcontrol\gsmartcontrol.conf"
<info>  [rconfig] Starting config autosave with 180 sec. interval.
<info>  [app] Current C locale: C
<info>  [app] Current C++ locale: C

(GSMART~1.EXE:23308): Gtk-WARNING **: Theme parsing error: gtk-win32-base.css:1043:59: Junk at end of value for background-image
<dump>  [app] Current GTK theme: win32

(GSMART~1.EXE:23308): Gtk-WARNING **: Could not find the icon 'drive-harddisk'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
        http://icon-theme.freedesktop.org/releases
<info>  [app] hz::data_file_find(): Data file "icon_hdd.png" found at ".".
<info>  [app] hz::data_file_find(): Data file "icon_cddvd.png" found at ".".
<info>  [app] get_smartctl_binary(): Smartmontools installation not found in "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\smartmontools\InstallLocation".
<dump>  [default] ENTER: "Cmdex::execute()"
<info>  [app] Cmdex::execute(): Executing "'smartctl-nc.exe' -V".
<dump>  [default] EXIT:  "Cmdex::execute()"
<dump>  [default] ENTER: "Cmdex::stopped_cleanup()"
<dump>  [default] ENTER: "Cmdex::unset_stop_timeouts()"
<dump>  [default] EXIT:  "Cmdex::unset_stop_timeouts()"
<dump>  [default] EXIT:  "Cmdex::stopped_cleanup()"
<dump>  [default] ENTER: "Cmdex::stopped_cleanup()"
@ashaduri ashaduri added the bug Something isn't working label Dec 1, 2021
@TonyApuzzo
Copy link
Author

TonyApuzzo commented Dec 9, 2021

This is on Windows 10 Pro 21H2

I noticed today that the problem seems to be invoking from command-line rather than using the NSIS versus zip.

Even when using the installer, it gsmartcontrol still fails to work correctly if you run it from powershell or cmd.

it's not the current directory but something about running from shell. I can run OK from Windows Explorer but I get the bad result launching the shortcut from PowerShell:

    PS C:\Users\tonya\scoop\apps\gsmartcontrol\1.1.3> start "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\GSmartControl.lnk"

@TonyApuzzo TonyApuzzo changed the title gsmartcontrol 1.1.3 windows 64 works via installer but fails when unzipped gsmartcontrol 1.1.3 windows 64 fails to run from command line (title edited) Dec 9, 2021
TonyApuzzo pushed a commit to TonyApuzzo/Extras that referenced this issue Dec 9, 2021
TonyApuzzo pushed a commit to TonyApuzzo/Extras that referenced this issue Dec 9, 2021
issaclin32 added a commit to ScoopInstaller/Extras that referenced this issue Dec 20, 2021
* amfora: Update to version 1.9.1

* cudatext: Update to version 1.151.1.0

* firefox-nightly: Update to version 97.0a1.20211208214306

* flutter: Update to version 2.8.0

* flyctl: Update to version 0.0.263

* hydrus-network: Update to version 465

* insomnia: Update to version 2021.7.1

* lightbulb: Update to version 2.4.1

* signal: Update to version 5.25.1

* tabby: Update to version 1.0.165

* tor-browser: Update to version 11.0.2

* vscode-portable: Update to version 1.63.0

* vscode: Update to version 1.63.0

* okular: Update to version 21.08.3-850

* vscodium-portable: Update to version 1.63.0

* vscodium: Update to version 1.63.0

* googlechrome-beta: Update to version 97.0.4692.45

* googlechrome-canary: Update to version 98.0.4755.0

* kate: Update to version 21.08.3-1496

* opera-gx: Update to version 82.0.4227.25

* firefox-nightly: Update to version 97.0a1.20211209093228

* flyctl: Update to version 0.0.264

* privoxy: Update to version 3.0.33

* tabby: Update to version 1.0.166

* vivaldi: Update to version 5.0.2497.28

* flyctl: Update to version 0.0.265

* oripa: Update to version 1.54

* postman: Update to version 9.4.0

* standardnotes: Update to version 3.9.8

* tabby: Update to version 1.0.167

* Add gsmartcontrol 1.1.3.

* fix: Workaround ashaduri/gsmartcontrol#20 by removing gsmartcontrol executable, run via start menu only.

* Update gsmartcontrol.json

* Update bucket/gsmartcontrol.json

Co-authored-by: Phani Rithvij <phanirithvij2000@gmail.com>

* Make changes per code review, add shortcut icon.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tony Apuzzo <tony.apuzzo@fdiinc.com>
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Co-authored-by: Issac Lin <issaclin32@gmail.com>
Co-authored-by: Phani Rithvij <phanirithvij2000@gmail.com>
@ashaduri
Copy link
Owner

Hi,

Thanks for the report.

This should be fixed in 0183626 and 235fba8, at least it fixed the issue for me when CWD is different from location of gsmartcontrol.exe, and the algorithm no longer depends on PATH.

@ashaduri ashaduri added fixed The issue has been fixed windows Windows-related issue labels Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed The issue has been fixed windows Windows-related issue
Projects
None yet
Development

No branches or pull requests

2 participants