Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system conflict with C++20 <version> header #14

Closed
ashaduri opened this issue Sep 27, 2021 · 1 comment
Closed

Build system conflict with C++20 <version> header #14

ashaduri opened this issue Sep 27, 2021 · 1 comment
Assignees
@ashaduri
Labels
bug Something isn't working fixed The issue has been fixed
Milestone
1.1.4

Comments

@ashaduri
Copy link
Owner

ashaduri commented Sep 27, 2021 •
edited
Loading

When compiling on macOS (using MacPorts, clang), autotools-generated version file conflicts with C++20 <version>, with clang finding local version file instead of the system-installed one.
This leads to compilation failure.

Other platforms may also be affected.

This affects autotools-based 1.1.3, but not the cmake-based main branch.
@ashaduri ashaduri added the bug Something isn't working label Sep 27, 2021
@ashaduri ashaduri self-assigned this Sep 27, 2021
@ashaduri ashaduri added this to the 1.1.4 milestone Sep 27, 2021
@Hao123br Hao123br mentioned this issue Oct 8, 2021
Closed
ashaduri added a commit that referenced this issue Dec 1, 2021
@ashaduri
Renamed the generated "version" file to "version.txt"; this fixes #14.
2bb98a4
@ashaduri
Copy link
Owner Author

ashaduri commented Dec 1, 2021 •
edited
Loading

Fixed in gsmartcontrol-gtk3 branch, 2bb98a4

@ashaduri ashaduri closed this as completed Dec 1, 2021
@ashaduri ashaduri added the fixed The issue has been fixed label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashaduri ashaduri

Labels
bug Something isn't working fixed The issue has been fixed
Projects
None yet
Milestone
1.1.4
Development

No branches or pull requests
1 participant
@ashaduri