Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump raw-window-handle to 0.6.0 #795

Closed
wants to merge 1 commit into from
Closed

Bump raw-window-handle to 0.6.0 #795

wants to merge 1 commit into from

Conversation

pengiie
Copy link

@pengiie pengiie commented Oct 10, 2023

Updated raw-window-handle to 0.6.0 and updated Changelog.md.
Waiting for rust-windowing/winit#3126 to update example using raw-window-handle

@pengiie
Copy link
Author

pengiie commented Oct 10, 2023

Should I modify to follow the rwh strategy in rust-windowing/winit#3126?

@MarijnS95
Copy link
Collaborator

Should I modify to follow the rwh strategy in rust-windowing/winit#3126?

I'm already working on this after implementing the producer end in the ndk. It's a tad unfortunate that backwards compatibility has to be implemented on both the producer and consumer end, which used to be provided by raw-window-handle around the 0.3/0.4 era (cc @notgull).

Do you need this change now-now, given that winit hasn't even finalized the change and released with it yet?

@pengiie
Copy link
Author

pengiie commented Oct 10, 2023

I don't need this now-now, just noticed the raw-window-handle update and didn't see a PR here for it yet, I'll close this and wait for your implementation with the backwards compatibility features

@pengiie pengiie closed this Oct 10, 2023
@notgull
Copy link

notgull commented Oct 10, 2023

I'm already working on this after implementing the producer end in the ndk. It's a tad unfortunate that backwards compatibility has to be implemented on both the producer and consumer end, which used to be provided by raw-window-handle around the 0.3/0.4 era (cc @notgull).

I wasn't aware that backwards compatibility used to be provided in-crate. Although translating a WindowHandle from 0.6 is probably harder than translating one from 0.4.

@MarijnS95
Copy link
Collaborator

I wasn't aware that backwards compatibility used to be provided in-crate. Although translating a WindowHandle from 0.6 is probably harder than translating one from 0.4.

Only in a 0.3 patch release for 0.4 iirc, I don't think the same was done for 0.4 <-> 0.5? And back then it was only one way around, from producer to consumer iirc.

MarijnS95 added a commit that referenced this pull request Oct 11, 2023
@MarijnS95
CI: Cross-lint for Mac, iOS and Windows
5a606e2 
We have some conditional code specific to Mac and iOS which is currently
untested in the CI, allowing non-compiling code in PRs like #795 to go
unnoticed.
MarijnS95 added a commit that referenced this pull request Oct 11, 2023
@MarijnS95
CI: Cross-lint for Mac, iOS and Windows
e5fdcc5 
We have some conditional code specific to Mac and iOS which is currently
untested in the CI, allowing non-compiling code in PRs like #795 to go
unnoticed.
MarijnS95 added a commit that referenced this pull request Oct 11, 2023
@MarijnS95
CI: Cross-lint for Mac, iOS and Windows
1ef89a4 
We have some conditional code specific to Mac and iOS which is currently
untested in the CI, allowing non-compiling code in PRs like #795 to go
unnoticed.
MarijnS95 added a commit that referenced this pull request Oct 11, 2023
@MarijnS95
CI: Cross-lint for Mac, iOS and Windows
fc2a433 
We have some conditional code specific to Mac and iOS which is currently
untested in the CI, allowing non-compiling code in PRs like #795 to go
unnoticed.
MarijnS95 added a commit that referenced this pull request Oct 11, 2023
@MarijnS95
CI: Cross-lint for Mac, iOS and Windows
268fb95 
We have some conditional code specific to Mac and iOS which is currently
untested in the CI, allowing non-compiling code in PRs like #795 to go
unnoticed.
@MarijnS95 MarijnS95 mentioned this pull request Oct 11, 2023
Merged
MarijnS95 added a commit that referenced this pull request Oct 11, 2023
@MarijnS95
CI: Cross-lint for Mac, iOS and Windows (#796)
49de034 
* CI: Cross-lint for Mac, iOS and Windows

We have some conditional code specific to Mac and iOS which is currently
untested in the CI, allowing non-compiling code in PRs like #795 to go
unnoticed.

* Fix new clippy lints
MarijnS95 added a commit that referenced this pull request Oct 11, 2023
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
4f57b93 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via #8 (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- `hinstance` is properly `Option`al?
MarijnS95 added a commit that referenced this pull request Oct 14, 2023
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
f6356f2 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via #8 (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- `hinstance` is properly `Option`al?
MarijnS95 added a commit that referenced this pull request Oct 14, 2023
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
2ac7248 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
@MarijnS95 MarijnS95 mentioned this pull request Oct 14, 2023
Merged
MarijnS95 added a commit that referenced this pull request Oct 14, 2023
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
7bd707d 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Oct 18, 2023
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
5fcf4da 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Oct 23, 2023
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
745f38d 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Nov 1, 2023
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
43f774c 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Dec 2, 2023
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
f22a3f7 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Mar 16, 2024
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
a15378f 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Mar 19, 2024
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
0be08ef 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Mar 24, 2024
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
996e97e 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Mar 24, 2024
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0
a1df052 
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
MarijnS95 added a commit that referenced this pull request Mar 24, 2024
@MarijnS95
ash-window: Upgrade to raw-window-handle 0.6.0 (#799)
9d225c5 
* ash-window: Upgrade to raw-window-handle 0.6.0

This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8

* ash-window/examples/winit: Demonstrate proper surface lifetime with `Suspended`/`Resumed` events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pengiie @MarijnS95 @notgull