Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when manage_relationship is called without opts #1408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drtheuns
Copy link

@drtheuns drtheuns commented Aug 26, 2024

Should it perhaps be implemented as a separate clause to avoid doing any needless work? E.g.:

def manage_relationship(changeset, _, _) do
  IO.warn("...")
  changeset
end

Fixes: #1407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manage_relationship should warn if the given options is empty
1 participant