Use specific commits from ruby-build. Allow Ruby 2.6.3 Installation #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing #108 and given ruby-build's reluctance to cut timely releases as stated therein and from the perspective of ruby-build users, move asdf-ruby to pulling specific commits from ruby-build.
|
Can we have this merged, please? |
|
It would sure be nice if they tagged new ruby-build versions each time they added support for a new Ruby version (or better yet, support new Ruby versions without requiring code changes). Using a specific commit is far better than using HEAD, and I think this will be a good compromise until they come up with a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #108 and given ruby-build's reluctance to cut timely releases as stated therein and from the perspective of ruby-build users, move asdf-ruby to pulling specific commits from ruby-build.
I understand our maintainer's perspective that this might be better addressed on ruby-build's side, but the question remains that we must move forward in the short term.