Reduce reshims in global installs #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add the same hook as postinstall on postuninstall
augustobmoura
changed the title
Closed
|
It would be really good if this were merged, any progress on the review? |
|
Closed in favor of #232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts the reshimming in global installs to only the packages being installed (or removed). Kinda solves #46, is not perfect, it will reshim multiple times if installing multiples packages (
npm i -g typescript tldrwill reshim 2 times for example) but I think it is in a much more comfortable state now. It's a bit better than #118, because in #118 it would reshim for every dependency that has a script bin, even though you don't use the binaries (npm i -g tldrfor example reshims 5 times and only provides 1 global command).Installing tldr dropped from ~12s to ~6s (the baseline without reshims is ~5s), other packages might see a bigger reduction, specially those with a bigger dependency tree.
closes #89