Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyupgrade use from pre-commit #1352

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Remove pyupgrade use from pre-commit #1352

merged 1 commit into from
Feb 7, 2023

Conversation

WilliamJamieson
Copy link
Contributor

All functionality from pyupgrade can now be fully replaced by ruff, see the completion of astral-sh/ruff#827.

This PR removes pyupgrade and configures ruff to take fully advantage of these changes.

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner February 7, 2023 15:18
zacharyburnett
zacharyburnett approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 9761bc9 into asdf-format:master Feb 7, 2023
@WilliamJamieson WilliamJamieson deleted the feature/remove_pyugrade branch February 7, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
No open projects
Ruff
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamJamieson @zacharyburnett