Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some libraries #15

Merged
merged 1 commit into from
Jul 17, 2018
Merged

update some libraries #15

merged 1 commit into from
Jul 17, 2018

Conversation

aadrian
Copy link
Contributor

@aadrian aadrian commented Sep 3, 2017

No description provided.

@lefou
Copy link
Member

lefou commented Sep 22, 2017

Thanks. Do the bumps have any consequences for the outcome of the plugin. I hesitate to drop compatibility to older Gitbucket versions (<4.16) so easily.

@aadrian
Copy link
Contributor Author

aadrian commented Sep 22, 2017

Do the bumps have any consequences for the outcome of the plugin.

Haven't noticed any yet, but there aren't (unit/integration) tests either to be more sure :( .

I hesitate to drop compatibility to older Gitbucket versions (<4.16) so easily.

You shall not: most plug-ins list a "version compatibility table", e.g. : https://github.com/gitbucket-plugins/gitbucket-explorer-plugin#version

Since each version has a tag, it's possible to make later a branch out of it and release a minor version if it's really needed to fix something for older versions.

On the other hand, regarding older versions of GitBucket, having hosted quite many instances so far, my experience is that it's far better to upgrade more often (~1 per month), and stay at max only a version behind the GitBucket latest.

@lefou lefou merged commit e5f835a into asciidoctor:master Jul 17, 2018
lefou added a commit that referenced this pull request Jul 17, 2018
# Conflicts:
#	.travis.yml
#	build.sbt
#	project/build.properties
#	project/plugins.sbt
#	src/main/scala/Plugin.scala
@lefou lefou added this to the 1.1.0 milestone Jul 17, 2018
@lefou
Copy link
Member

lefou commented Jul 17, 2018

Thank you

@aadrian aadrian deleted the patch-1 branch July 17, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants