Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JUnit to v5 and remove unused build elements #97

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Sep 3, 2023

Kind of change

[ ] Bug fix
[x] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[x] Build improvement

Description

What is the goal of this pull request?

Initially bump JUnit to latests v5. But also includes some cleanup of the build scripts that I detected:

  • Remove un-used Groovy/Spock elements
  • Remove un-used Bintray configurations
  • Remove un-used AppVeyor config

How does it achieve that?

Bump dependencies and adapt tests code to the new JUnit APIs.

Are there any alternative ways to implement this?

No

Are there any implications of this pull request? Anything a user must know?

No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

* Remove Goorvy/Spock un-necessary build config
* Remove un-used AppVeyor
* Remove un-used Bintray from build
@robertpanzer
Copy link
Member

Thank you!

@robertpanzer robertpanzer merged commit 9d098e5 into asciidoctor:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants