Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel Asciidoctor line-height in highlight.js table (fixes #331) #334

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Cancel Asciidoctor line-height in highlight.js table (fixes #331) #334

merged 2 commits into from
Feb 14, 2020

Conversation

obilodeau
Copy link
Member

arjs-hls-fix

@obilodeau obilodeau requested a review from ggrossetie February 11, 2020 04:03
@obilodeau obilodeau added this to the 4.0.0 milestone Feb 11, 2020
@obilodeau obilodeau mentioned this pull request Feb 11, 2020
Closed
@obilodeau obilodeau force-pushed the fix-highlightjs-table-line-height branch from d4c1019 to b4af530 Compare February 11, 2020 04:19
@obilodeau
Copy link
Member Author

Rebased on master because I fixed some tests failing on master here: bebd4c9

@ggrossetie
Copy link
Member

@obilodeau Could you please add an example with the "ASM slide"?

@obilodeau
Copy link
Member Author

Added an example at the end of examples/source-emphasis.adoc

@obilodeau obilodeau mentioned this pull request Feb 11, 2020
Merged
ggrossetie
ggrossetie approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@obilodeau obilodeau merged commit 57f68fd into asciidoctor:master Feb 14, 2020
@obilodeau obilodeau deleted the fix-highlightjs-table-line-height branch February 14, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie approved these changes

Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@obilodeau @ggrossetie