Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt at fixing recent Travis JRuby build failures #295

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Attempt at fixing recent Travis JRuby build failures #295

merged 2 commits into from
Dec 23, 2019

Conversation

obilodeau
Copy link
Member

jruby-9k seems to provide a version no longer compatible with bundler.

See build failure in #292.

@obilodeau
Copy link
Member Author

It fixed it! Will merge unless someone convinces me that it's wrong. Per policy, you have 24 hours 😄

@obilodeau obilodeau mentioned this pull request Dec 20, 2019
Merged
@ggrossetie
Copy link
Member

Nice!
Here's the link to the failing build: https://travis-ci.org/asciidoctor/asciidoctor-reveal.js/jobs/627564886
And the backtrace for reference:

NoMethodError: undefined method `[]' for nil:NilClass
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/source/git/git_proxy.rb:90:in `version'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/source/git/git_proxy.rb:147:in `block in copy_to'
  org/jruby/RubyDir.java:399:in `chdir'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/shared_helpers.rb:52:in `block in chdir'
  /home/travis/.rvm/rubies/jruby-9.2.5.0/lib/ruby/stdlib/monitor.rb:226:in `mon_synchronize'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/shared_helpers.rb:51:in `chdir'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/source/git/git_proxy.rb:136:in `copy_to'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/source/git.rb:163:in `specs'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/definition.rb:764:in `block in converge_locked_specs'
  org/jruby/RubyArray.java:1792:in `each'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/definition.rb:750:in `converge_locked_specs'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/definition.rb:247:in `resolve'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/definition.rb:170:in `specs'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/definition.rb:158:in `resolve_remotely!'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/installer.rb:303:in `resolve_if_needed'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/installer.rb:84:in `block in run'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/process_lock.rb:12:in `block in lock'
  org/jruby/RubyIO.java:1154:in `open'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/process_lock.rb:9:in `lock'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/installer.rb:73:in `run'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/installer.rb:25:in `install'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/cli/install.rb:65:in `run'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/cli.rb:256:in `block in install'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/settings.rb:124:in `temporary'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/cli.rb:255:in `install'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/vendor/thor/lib/thor.rb:399:in `dispatch'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/cli.rb:30:in `dispatch'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/vendor/thor/lib/thor/base.rb:476:in `start'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/cli.rb:24:in `start'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/exe/bundle:46:in `block in <main>'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/lib/bundler/friendly_errors.rb:123:in `with_friendly_errors'
  /home/travis/.rvm/gems/jruby-9.2.5.0/gems/bundler-2.1.2/exe/bundle:34:in `<main>'
  org/jruby/RubyKernel.java:1007:in `load'
  /home/travis/.rvm/gems/jruby-9.2.5.0/bin/bundle:1:in `(root)'
  org/jruby/RubyKernel.java:1046:in `eval'
  /home/travis/.rvm/gems/jruby-9.2.5.0/bin/jruby_executable_hooks:24:in `<main>'

ggrossetie
ggrossetie reviewed Dec 21, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@obilodeau @ggrossetie
Update .travis.yml
f9f92aa 
As discussed, tracking current latest stable instead of `jruby-head` which includes snapshots and unstable versions.

Co-Authored-By: Guillaume Grossetie <g.grossetie@gmail.com>
@obilodeau obilodeau merged commit d454ab0 into asciidoctor:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie left review comments

@mojavelinux mojavelinux mojavelinux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obilodeau @ggrossetie @mojavelinux