Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a neutral background color for callout #293

Closed
ggrossetie opened this issue Dec 18, 2019 · 1 comment
Closed

Use a neutral background color for callout #293

ggrossetie opened this issue Dec 18, 2019 · 1 comment

Comments

@ggrossetie
Copy link
Member

Is there a particular reason to use a green background on callout?

.conum[data-value] {display:inline-block;color:#fff!important;background-color:rgba(50,150,50,.8);-webkit-border-radius:100px;border-radius:100px;text-align:center;font-size:.75em;width:1.67em;height:1.67em;line-height:1.67em;font-family:"Open Sans","DejaVu Sans",sans-serif;font-style:normal;font-weight:bold}

The default stylesheet is using a black background with a with font:

.conum[data-value] {
  color: #fff!important;
  background: rgba(0,0,0,.8);
}

https://github.com/asciidoctor/asciidoctor/blob/master/data/stylesheets/asciidoctor-default.css

I think we should use a neutral color because depending on the chosen reveal.js theme, this green background might look out of place.

@obilodeau
Copy link
Member

No particular reason. I'm pretty sure I just inlined Asciidoctor's (at the time) CSS.

Syncing that style with upstream is reasonable to me.

@obilodeau obilodeau added this to the 3.0.0 milestone Dec 23, 2019
obilodeau added a commit that referenced this issue Dec 30, 2019
Synced callout style with upstream Asciidoctor (fixes #293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants