-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync to Asciidoctor.js' 1.5.9 (and matching Opal) #227
Comments
I tried to combine https://github.com/eshepelyuk/asciidoctor-plantuml.js and asciidoctor-reveal.js and pretty much immediately ran into #187 (comment) (i.e. the opal-exception) which is a pretty nasty error message to debug for an end user 😉 |
BTW: If I force |
That's literally what we're working on right now. There's a whole bunch of improvements coming to these integration layers, underpinned by a switch to semantic versioning. This extension will obviously be a good test of how it's coming along. |
Cool, I'll watch out for improvements and test them. Without the plant-uml plugin it was smooth sailing before, will be cool to write reveal presentations in AsciiDoc with integrated PlantUML support 😄 |
In the meantime you can try to use the Ruby toolkit: Asciidoctor + asciidoctor-diagram |
Thanks @obilodeau, I've tried to get this to work with Gradle / JRuby, but I've failed as well with
Maybe I'll try the plain Ruby stack in the end (or just use RevealJS with Markdown and generate the PlantUML statically, even if it's not as convenient) |
What's the issue with the Java stack? If it's using jruby and
asciidoctor-diagram works with it then it should just work with revealjs
too.
Le sam. 19 janv. 2019 10 h 15 a.m., Peter Gafert <notifications@github.com>
a écrit :
… Thanks @obilodeau <https://github.com/obilodeau>, I've tried to get this
to work with Gradle / JRuby, but I've failed as well with
- https://plugins.gradle.org/plugin/org.asciidoctor.jvm.revealjs
-
https://github.com/asciidoctor/asciidoctor-gradle-examples/tree/master/asciidoc-to-revealjs-example
Maybe I'll try the plain Ruby stack in the end (or just use RevealJS with
Markdown and generate the PlantUML statically, even if it's not as
convenient)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhWFRHgNIenuacT640hhzLr_4jMbPRtks5vEzZjgaJpZM4Y0cGp>
.
|
With the new alpha version of the revealjs plugin I always either got something like "asciidoctorj is missing" or "can't add asciidoctorj as it is already present", no matter which combination I've tried.
I really stripped the asciidoc down quite a lot and it should be the same as in the example, so I don't know (I saw an issue though in the example repo that had pretty much the same error message, don't know if it's related) |
Yeah, I totally understand how time sensitive is preparing a presentation. Quick hacks are way better than a slide-deck with no diagrams on the stage 😆 Once the release will be done let's look at this again but in another ticket because this ticket got side-tracked here. Getting back on track, I will sync to Asciidoctor.js 1.5.9 and matching Opal in a PR that should be submitted soon. |
Javascript/Node: Sync with Asciidoctor.js 1.5.9 (fixes #227)
We post-poned #187. It means we specify asciidoctor.js' dependency still. A major release means we should sync with the latest code.
Opal is only required as a devDep, make sure it's not pulled-in in ruby environments if we specify a special version in the Gemfile.
The text was updated successfully, but these errors were encountered: