Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow AsciiDoc table cell to overrun bottom of page on which it fits #2538

Closed
mojavelinux opened this issue Sep 19, 2024 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@mojavelinux
Copy link
Member

mojavelinux commented Sep 19, 2024

It's possible for the height reserved for the AsciiDoc table cell to be insufficient due to rounding and estimation errors. As a result, a cell which should fit on a page is truncated and a warning is issue that the cell exceeds the height of the page.

Once the cell is determined to fit on the page, the height of the box in which to draw the content should be equal to the writable area of the page (minus the top and bottom padding of the cell). That way, a warning is only issued if the height of the content truly is greater than the height of the page and any false warnings can be avoided.

@mojavelinux mojavelinux self-assigned this Sep 19, 2024
@mojavelinux mojavelinux added this to the v2.3.x milestone Sep 19, 2024
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Sep 19, 2024
mojavelinux added a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant